@bkhizgiy hi, please take a look,

Notes:

• when no rootDisk defined user see "First disk"
• when user choose "First disk" the rootDisk is removed from the yaml
• rootDisk is a string with values:
  '' - first disk
  '2' - second disc
  '3' - third ...
• All vms has the same rootDisk value
• If the UI see a manually edited rootDisk that has different rootDisk for some VMs, a warning is showed

Example o spec.vms with rootDisk:

vms:
    - id: vm-55
      name: DC0_H0_VM0
      rootDisk: '2'
    - id: vm-58
      name: DC0_H0_VM1
      rootDisk: '2'
    - id: vm-61
      name: DC0_C0_RP0_VM0
      rootDisk: '2'
    - id: vm-64
      name: DC0_C0_RP0_VM1
      rootDisk: '2'

waiting for: kubev2v/forklift#873

Following our conversation, we have decided to update the string input in the UI to specify both the disk and partition the user wishes to set as the root.

For example:

For the first disk, please use the input sda.
For the second disk, please use the input sdb.
For the first partition of the first disk, please use the input sda1.
For the second partition of the second disk, please use the input sdb2.
And so on....

For help text we can add something of a sort:
When using a multi-boot VM, you can specify a particular root device. For example, sdb will refer to the second disk, while sda1 or sda2 will refer to the first or second partition on the first hard drive, respectively. If the specified root device does not exist or was not detected as a root device, the VM conversion will fail. For additional information see documentation

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bkhizgiy hi,

updates:
a. a user can enter any string as a root disk, no verification.
b. a set of pre defined root devices is available:

export const diskOptions = (t = (text: string) => text): DiskOption[] => [
  { key: '', description: t('Boot from first root device') },
  { key: 'sda', description: t('Boot from the first hard drive') },
  {
    key: 'sda1',
    description: t('Boot from the first partition on the first hard drive'),
  },
  {
    key: 'sda2',
    description: t('Boot from the second partition on the first hard drive'),
  },
  { key: 'sdb', description: t('Boot from the second hard drive') },
  {
    key: 'sdb1',
    description: t('Boot from the first partition on the second hard drive'),
  },
  {
    key: 'sdb2',
    description: t('Boot from the second partition on the second hard drive'),
  },
];

c. user can create new root device strings that are not in the pre defined options
d. in the YAML:

vms:
    - id: vm-23113
      name: mtv-rhel8-warm-sanity-nfs
      rootDisk: sdd
    - id: vm-23159
      name: mtv-rhel8-warm-sanity
      rootDisk: sdd

e. i also updated the description screenshots

@bkhizgiy hi,
update:
a. added /dev/ to the rootDisk string, YAML now looks:

vms:
    - id: vm-23113
      name: mtv-rhel8-warm-sanity-nfs
      rootDisk: /dev/sda1
    - id: vm-23159
      name: mtv-rhel8-warm-sanity
      rootDisk: /dev/sda1